Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws-sdk v2 in the trusted advisor check #550

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Conversation

manelmontilla
Copy link
Contributor

@manelmontilla manelmontilla commented Feb 7, 2024

This PR introduces the following modifications to the vulcan-aws-trusted-advisor check:

  • Migrate the code to use the go AWS sdk v2. The v2 comes out of the box with a retrier that should prevent throttling errors.
  • Avoid an out of bound access to a slice in some situations.
  • Fixed some minor styling issues.
  • Allow the check to get the AWS credentials from the process env vars, so it's easier to run it locally.

@manelmontilla manelmontilla force-pushed the fix-aws-trusted-advisor branch 3 times, most recently from bc0269b to a134a65 Compare February 9, 2024 11:20
@manelmontilla manelmontilla marked this pull request as ready for review February 15, 2024 13:58
@jesusfcr jesusfcr force-pushed the fix-aws-trusted-advisor branch 2 times, most recently from 9f8d4a0 to 211e970 Compare July 10, 2024 10:18
@jesusfcr jesusfcr force-pushed the fix-aws-trusted-advisor branch from 5858d78 to b2c7b10 Compare July 10, 2024 16:10
@jesusfcr jesusfcr force-pushed the fix-aws-trusted-advisor branch from b2c7b10 to a4a9c45 Compare July 11, 2024 07:47
@jesusfcr jesusfcr requested a review from danfaizer July 12, 2024 09:30
jesusfcr
jesusfcr previously approved these changes Jul 12, 2024
Copy link
Contributor

@danfaizer danfaizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jesusfcr jesusfcr merged commit d048c22 into master Jul 15, 2024
2 checks passed
@jesusfcr jesusfcr deleted the fix-aws-trusted-advisor branch July 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants