Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '--chown' from COPY instruction, as user no longer exists #549

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

kozmic
Copy link
Contributor

@kozmic kozmic commented Feb 5, 2024

The user 'gitleaks' was removed in this commit upstream: gitleaks/gitleaks@ac4b514

When building this check now, it will fail with the error:

unable to convert uid/gid chown string to host mapping

Removing this argument pointing to a user that does not exists should fix the issue.

The user 'gitleaks' was removed in this commit upstream:
gitleaks/gitleaks@ac4b514

When building this check now, it will fail with the error:
```
unable to convert uid/gid chown string to host mapping
```
Removing this argument pointing to a user that does not exists should fix the issue.
Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR

Do you mind to pin the base image to the latest zricethezav/gitleaks:v8.18.2 in order to prevent this to happen again?

Later we should add the docker image to the dependabot config file and add the proper tests to allow safe upgrades.

To avoid random breakage in the future, let's pin the version of upstream version
@kozmic
Copy link
Contributor Author

kozmic commented Feb 5, 2024

@jesusfcr : Good suggestion, should be fixed in 86c6f49.

Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@jesusfcr jesusfcr enabled auto-merge (squash) February 5, 2024 12:49
@jesusfcr jesusfcr merged commit 274814b into adevinta:master Feb 5, 2024
1 check passed
@kozmic kozmic deleted the patch-2 branch February 5, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants