fix(dialog): adjust the handling of the hasCloseButton flag to avoid a potential infinite loop with React 19 #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acd02
added
Type: Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
- Coverage 97.56% 97.56% -0.01%
==========================================
Files 760 760
Lines 6008 6001 -7
Branches 2138 2137 -1
==========================================
- Hits 5862 5855 -7
Misses 144 144
Partials 2 2 ☔ View full report in Codecov by Sentry. |
acd02
force-pushed
the
fix-dialog-popover-hasbutton
branch
from
0a634f1 to
a56ac6d
Compare
acd02
changed the title
acd02
force-pushed
the
fix-dialog-popover-hasbutton
branch
from
a56ac6d to
792a1ac
Compare
…ntial infinite loop (React 19) use css :has selector + group tailwind modifer instead of relying on JS
acd02
force-pushed
the
fix-dialog-popover-hasbutton
branch
from
792a1ac to
9a6db95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(dialog)
Description, Motivation and Context
Adjust the handling of the hasCloseButton flag to avoid a potential infinite loop with React 19
Types of changes