Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): accordion item header #2245

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat(accordion): accordion item header #2245

merged 1 commit into from
Jun 17, 2024

Conversation

Powerplex
Copy link
Contributor

TASK: #2058

Description, Motivation and Context

Managing heading levels for Accordion items triggers. As per ARIA accordion pattern guidelines:

Each accordion header button is wrapped in an element with role [heading](https://w3c.github.io/aria/#heading) that has a value set for [aria-level](https://w3c.github.io/aria/#aria-level) that is appropriate for the information architecture of the page.

https://www.w3.org/WAI/ARIA/apg/patterns/accordion/

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.56%. Comparing base (309ec9b) to head (bef11fc).
Report is 2 commits behind head on main.

Files Patch % Lines
...s/components/accordion/src/AccordionItemHeader.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2245      +/-   ##
==========================================
- Coverage   97.61%   97.56%   -0.05%     
==========================================
  Files         759      760       +1     
  Lines        6000     6006       +6     
  Branches     2098     2136      +38     
==========================================
+ Hits         5857     5860       +3     
- Misses        141      144       +3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex merged commit ec600c6 into main Jun 17, 2024
10 of 11 checks passed
@Powerplex Powerplex deleted the accordion-header branch June 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants