feat: query-parameters persisting when opening a story on a full-view-mode #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-a-story-into-a-tab' into dark-mode-persisted-when-opening-a-story-into-a-tab
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1845 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 709 709
Lines 5042 5042
Branches 1836 1836
=======================================
Hits 4944 4944
Misses 98 98 ☔ View full report in Codecov by Sentry. |
andresin87
changed the title
Powerplex
approved these changes
Jan 26, 2024
3 tasks
acd02
reviewed
Jan 29, 2024
package.json
Outdated
| @@ -109,6 +109,7 @@ | |||
| "postcss": "8.4.31", | |||
| "prettier": "3.2.4", | |||
| "prettier-plugin-tailwindcss": "0.5.11", | |||
| "query-string": "^8.1.0", | |||
There was a problem hiding this comment.
Couldn't we use the URLSearchParams API instead?
acd02
approved these changes
Jan 29, 2024
andresin87
deleted the
dark-mode-persisted-when-opening-a-story-into-a-tab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK:
Description, Motivation and Context
Types of changes
Screenshots - Animations