Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): broken popover arrow caused by relative positionning #1821

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Powerplex
Copy link
Contributor

Description, Motivation and Context

Removing relative class on Popover.Content as it breaks Popover.Arrow positionning.

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2c1271) 98.05% compared to head (4f239ad) 98.05%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         710      710           
  Lines        5045     5045           
  Branches     1833     1833           
=======================================
  Hits         4947     4947           
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex merged commit ad07fd1 into main Jan 18, 2024
9 of 11 checks passed
@Powerplex Powerplex deleted the debug-popover-arrow branch January 18, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant