Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): merge dropdown logic into select #1794

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Powerplex
Copy link
Contributor

TYPE(SCOPE): TITLE

TASK: #1793

Description, Motivation and Context

Most of the work that has been approved for the dropdown is merged into Select in the PR.
The code had to be adapted to match the HTML select API.

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6fba6dc) 98.00% compared to head (50a190d) 98.06%.
Report is 14 commits behind head on main.

Files Patch % Lines
packages/components/select/src/SelectContext.tsx 96.55% 1 Missing ⚠️
.../components/select/src/SelectItemsGroupContext.tsx 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
+ Coverage   98.00%   98.06%   +0.06%     
==========================================
  Files         695      699       +4     
  Lines        4910     4960      +50     
  Branches     1790     1809      +19     
==========================================
+ Hits         4812     4864      +52     
+ Misses         98       96       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex force-pushed the select-with-dropdown-logic branch from 22b4728 to 50a190d Compare January 5, 2024 14:13
@Powerplex Powerplex merged commit 4effb61 into main Jan 5, 2024
10 of 11 checks passed
@Powerplex Powerplex deleted the select-with-dropdown-logic branch January 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant