Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): dropdown states #1753

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

Powerplex
Copy link
Contributor

@Powerplex Powerplex commented Dec 14, 2023

TYPE(SCOPE): TITLE

TASK: #1752

Description, Motivation and Context

Implementing states for dropdown trigger:

  • error, alert and success states.
  • a state indicator is displayed (icon) for colorblind people who can't see the outline color.
  • Focus styles have been updated to match the Figma specs

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)
  • 🧾 Documentation
  • 💄 Styles

Capture d’écran 2023-12-14 à 17 42 19

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc7ed15) 97.97% compared to head (21aacb8) 97.98%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1753   +/-   ##
=======================================
  Coverage   97.97%   97.98%           
=======================================
  Files         692      693    +1     
  Lines        4887     4902   +15     
  Branches     1783     1785    +2     
=======================================
+ Hits         4788     4803   +15     
  Misses         99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex merged commit 1bb8b91 into main Dec 19, 2023
10 of 11 checks passed
@Powerplex Powerplex deleted the 1752-components-dropdown-statuses branch December 19, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Components] - Dropdown - statuses
2 participants