Controlled multiple selection #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
b31d67e to
1a48d8a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
=======================================
Coverage 97.94% 97.95%
=======================================
Files 692 692
Lines 4873 4882 +9
Branches 1770 1780 +10
=======================================
+ Hits 4773 4782 +9
Misses 100 100 ☔ View full report in Codecov by Sentry. |
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
1a48d8a to
53763f6
Compare
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
53763f6 to
df658e9
Compare
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
df658e9 to
542961d
Compare
andresin87
approved these changes
Dec 7, 2023
andresin87
added
enhancement
Component
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
542961d to
4630ae6
Compare
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
4630ae6 to
4a9a0b8
Compare
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
4a9a0b8 to
cec735a
Compare
Powerplex
force-pushed
the
controlled-multiple-selection
branch
from
cec735a to
e463702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE(SCOPE): TITLE
TASK: #1687
Description, Motivation and Context
Controlled mode is now managing array of strings for
multipleselection mode.value,onValueChangeanddefaultValuenow accepts array of strings.multipleprop helps TS infer that those prop have the correct type for the userTypes of changes