Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progress-tracker): add base markup for progress-tracker #1714

Merged
merged 15 commits into from
Jan 5, 2024

Conversation

soykje
Copy link
Contributor

@soykje soykje commented Dec 1, 2023

TASK: #1581

Description, Motivation and Context

Getting started with component, with base features.

NB: Interactivity behaviour will be updated/refactored after specs updates, in further PR.

Types of changes

  • ✨ New feature (non-breaking change which adds functionality)
  • 🧾 Documentation
  • 🧪 Test
  • 💄 Styles

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40ebca8) 97.98% compared to head (0ba3e16) 98.03%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
+ Coverage   97.98%   98.03%   +0.04%     
==========================================
  Files         694      704      +10     
  Lines        4908     4979      +71     
  Branches     1790     1809      +19     
==========================================
+ Hits         4809     4881      +72     
+ Misses         99       98       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soykje soykje force-pushed the progress-tracker-base branch from 4dfe938 to d98c374 Compare December 4, 2023 11:52
@soykje soykje force-pushed the progress-tracker-base branch from d98c374 to b8c14dc Compare December 5, 2023 10:04
@soykje soykje force-pushed the progress-tracker-base branch from b8c14dc to 1d34cbf Compare December 5, 2023 10:25
@soykje soykje force-pushed the progress-tracker-base branch from ce71b1b to 62cb6d5 Compare December 5, 2023 16:10
@soykje soykje force-pushed the progress-tracker-base branch from 62cb6d5 to 045a052 Compare December 5, 2023 16:30
@soykje soykje force-pushed the progress-tracker-base branch from 6cbc856 to a8daab4 Compare December 6, 2023 09:39
@soykje soykje force-pushed the progress-tracker-base branch from a8daab4 to 1e07cbb Compare December 6, 2023 09:42
@soykje soykje force-pushed the progress-tracker-base branch from 9e84ba6 to 3253646 Compare December 6, 2023 13:31
@soykje soykje force-pushed the progress-tracker-base branch from 3253646 to 7f27df7 Compare December 7, 2023 08:43
@soykje soykje force-pushed the progress-tracker-base branch from 7f27df7 to 0aee474 Compare December 7, 2023 09:14
@soykje soykje force-pushed the progress-tracker-base branch from 0aee474 to 4d23fb2 Compare December 7, 2023 10:36
@andresin87
Copy link
Member

It looks like there is a problem with the interaction on this PR

Grabacion.de.pantalla.2024-01-04.a.las.9.49.39.mov

We need to review at the end of all the PRs

@andresin87
Copy link
Member

progress-tracker is using basic, main, support naming convention and this is only availabe using
"@spark-ui/theme-utils": "^4.0.0",
as a peer-dependency. Please do not forget

@soykje soykje merged commit e6279f7 into main Jan 5, 2024
10 of 11 checks passed
@soykje soykje deleted the progress-tracker-base branch January 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component Related to a component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants