Merge pull request #2111 from adevinta/preserve-combobox-cursor-position

fix(combobox): preserve combobox cursor position upon change
adevinta · May 3, 2024 · cf1b3cf · cf1b3cf
2 parents 35c2ce5 + 4ba34da
commit cf1b3cf
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/packages/components/combobox/src/ComboboxInput.tsx b/packages/components/combobox/src/ComboboxInput.tsx
@@ -63,6 +63,15 @@ export const Input = forwardRef(
         multiselectInputProps.onKeyDown?.(event)
         ctx.setLastInteractionType('keyboard')
       },
+      /**
+       *
+       * Important:
+       * - without this, the input cursor is moved to the end after every change.
+       * @see https://github.com/downshift-js/downshift/issues/1108#issuecomment-674180157
+       */
+      onChange: (e: React.ChangeEvent<HTMLInputElement>) => {
+        ctx.setInputValue(e.target.value)
+      },
       ref: inputRef,
     })