Merge pull request #1843 from adevinta/fix-item-indicator-safari

fix(dropdown): fixed missing ItemIndicator on Safari
adevinta · Jan 29, 2024 · ccf6b17 · ccf6b17
2 parents 7fed9d3 + dd1dd6d
commit ccf6b17
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/components/dropdown/src/DropdownItemIndicator.tsx b/packages/components/dropdown/src/DropdownItemIndicator.tsx
@@ -1,8 +1,8 @@
+import { Icon } from '@spark-ui/icon'
 import { Check } from '@spark-ui/icons/dist/icons/Check'
 import { cx } from 'class-variance-authority'
 import { forwardRef, ReactNode, type Ref } from 'react'
 
-import { useDropdownContext } from './DropdownContext'
 import { useDropdownItemContext } from './DropdownItemContext'
 
 export interface ItemIndicatorProps {
@@ -14,9 +14,12 @@ export interface ItemIndicatorProps {
 export const ItemIndicator = forwardRef(
   ({ className, children, label }: ItemIndicatorProps, forwardedRef: Ref<HTMLSpanElement>) => {
     const { disabled, isSelected } = useDropdownItemContext()
-    const { multiple } = useDropdownContext()
-    const childElement =
-      children || (multiple ? <Check aria-label={label} /> : <span aria-label={label}>✓</span>)
+
+    const childElement = children || (
+      <Icon size="sm">
+        <Check aria-label={label} />
+      </Icon>
+    )
 
     return (
       <span