Skip to content

Commit

Permalink
fix(spinner): set spinner as span
Browse files Browse the repository at this point in the history
when used as a div inside a loading button, it makes the html invalid
  • Loading branch information
Powerplex committed Jan 16, 2025
1 parent 60082d8 commit 91bb67d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/components/spinner/src/Spinner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ export const Spinner = ({
...others
}: PropsWithChildren<SpinnerProps>) => {
return (
<div
<span
role="status"
data-spark-component="spinner"
ref={ref}
className={spinnerStyles({ className, size, intent, isBackgroundVisible })}
{...others}
>
{label && <VisuallyHidden>{label}</VisuallyHidden>}
</div>
</span>
)
}

0 comments on commit 91bb67d

Please sign in to comment.