Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IRP] Remove common code #993

Closed
wants to merge 1 commit into from
Closed

[IRP] Remove common code #993

wants to merge 1 commit into from

Conversation

robergro
Copy link
Contributor

@robergro robergro commented Jun 7, 2024

  • All the common code are removed
  • Update xcodegen config to use the spark-ios-common and spark-ios-theming package.

Note: The snapshot testing are broken. It will be fixed when we will moved all components on dedicated spm.

@robergro robergro linked an issue Jun 7, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@michael-zimmermann michael-zimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflict with the if modifier, is that I added a deprecated to it.
@available(*, deprecated, message: "Will be removed soon")

@michael-zimmermann michael-zimmermann deleted the spm-migration branch June 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IRP] Theming Package
2 participants