-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refacto-557] Button: Add UIControl #588
Conversation
robergro
commented
Oct 30, 2023
•
edited
Loading
edited
- Add UIControl on Button
- Deprecate old var, func and init
- Add setImage, setTitle, setAttributed methods
- Override isSelected, isEnabled and isHighlighted var
- Update the demo
- Update the Wiki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo Thank you @michael-zimmermann , It not solve everything but it's better. So now, we can have a problem if the button has just an icon (on normal mode) and image + text (on highlighted mode) because the size of the button is a square. This is why i need to split the component to:
And I hope with that, all our problems will be solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need a bit more testing, to continue :)
ba5f371
to
096dc80
Compare
core/Sources/Common/Control/PropertyStates/ControlPropertyStates.swift
Outdated
Show resolved
Hide resolved
f68cc2f
to
eb30f56
Compare
Revert "Merge pull request #588 from adevinta/refacto/button/integrat…