[RadioButton#449] Updated RadioButton colors for intents danger, aler…

…t and success.
adevinta · Oct 30, 2023 · a564b4d · a564b4d
1 parent 64e13de
commit a564b4d
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 3 deletions.
diff --git a/core/Sources/Components/RadioButton/UseCases/RadioButtonGetColorsUseCase.swift b/core/Sources/Components/RadioButton/UseCases/RadioButtonGetColorsUseCase.swift
@@ -53,7 +53,19 @@ private extension SparkCore.Colors {
     func buttonColor(
         intent: RadioButtonIntent,
         isSelected: Bool) -> any ColorToken {
-            return  isSelected ? self.selectedColor(intent: intent) : self.base.outline
+            return  isSelected ? self.selectedColor(intent: intent) : self.outlineColor(intent: intent)
+    }
+
+    private func outlineColor(intent: RadioButtonIntent) -> any ColorToken {
+        switch intent {
+        case .danger:
+            return self.feedback.error
+        case .alert:
+            return self.feedback.alert
+        case .success:
+            return self.feedback.success
+        default: return self.base.outline
+        }
     }
 
     private func selectedColor(intent: RadioButtonIntent) -> any ColorToken {

diff --git a/core/Sources/Components/RadioButton/UseCases/RadioButtonGetColorsUseCaseTests.swift b/core/Sources/Components/RadioButton/UseCases/RadioButtonGetColorsUseCaseTests.swift
@@ -54,7 +54,7 @@ final class RadioButtonGetColorsUseCaseTests: XCTestCase {
         // Given
         let colors = self.theme.colors
         let expectedColors = RadioButtonColors(
-            button: colors.base.outline,
+            button: colors.feedback.error,
             label: colors.base.onBackground,
             halo: colors.feedback.errorContainer,
             fill: ColorTokenDefault.clear,
@@ -92,11 +92,32 @@ final class RadioButtonGetColorsUseCaseTests: XCTestCase {
         XCTAssertEqual(givenColors, expectedColors)
     }
 
+    func test_alert_colors_when_button_is_not_selected() throws {
+        // Given
+        let colors = self.theme.colors
+        let expectedColors = RadioButtonColors(
+            button: colors.feedback.alert,
+            label: colors.base.onBackground,
+            halo: colors.feedback.alertContainer,
+            fill: ColorTokenDefault.clear,
+            surface: colors.feedback.onAlert
+        )
+
+        // When
+        let givenColors = self.sut.execute(
+            theme: self.theme,
+            intent: .alert,
+            isSelected: false)
+
+        // Then
+        XCTAssertEqual(givenColors, expectedColors)
+    }
+
     func test_success_colors_when_button_is_not_selected() throws {
         // Given
         let colors = self.theme.colors
         let expectedColors = RadioButtonColors(
-            button: colors.base.outline,
+            button: colors.feedback.success,
             label: colors.base.onBackground,
             halo: colors.feedback.successContainer,
             fill: ColorTokenDefault.clear,