Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/lava: allow to specify the minimum severity required to show a finding #87

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

jroimartin
Copy link
Contributor

This PR adds the field report.show to the Lava configuration
file. It allows to specify the minimum severity required to show a
finding. Similarly, it adds the flag -show to the lava run
command.

This change allows to use different severity thresholds to exit with
error and to generate the report.

@jroimartin jroimartin requested review from seilagamo and jesusfcr July 11, 2024 15:04
Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seilagamo seilagamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!!!

@jroimartin jroimartin merged commit 7a9bd78 into main Jul 12, 2024
6 checks passed
@jroimartin jroimartin deleted the report-show branch July 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants