Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/urlutil: support downloading OCI artifacts #33

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jroimartin
Copy link
Contributor

@jroimartin jroimartin commented Nov 24, 2023

This PR adds support for downloading OCI artifacts to the package
internal/urlutil. It adds support for a new scheme:

  • oci://: OCI artifact (via HTTPs)

This enables us to distribute checktype catalogs as OCI artifacts.

Registry authentication will be added in a future PR.

Copy link
Contributor

@jesusfcr jesusfcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seilagamo seilagamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jroimartin jroimartin force-pushed the oci branch 2 times, most recently from c940a0b to ff3be14 Compare December 1, 2023 07:27
@jroimartin
Copy link
Contributor Author

jroimartin commented Dec 1, 2023

I have converted this PR into a draft. We don't have enough experience dealing with OCI artifacts and it seems a bit risky to support them from v1.0.0. On the other hand, it is clear that we have to support HTTP (which is already implemented). So, let's start by serving the catalog via HTTP.

@jroimartin jroimartin added the poc Proof of concept label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
poc Proof of concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants