When there are multiple actions in the queue, only call the "updated" methods for the last action #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype to solve for #696. It changes the semantics of how the updated methods work, though -- instead of getting called for every action, when there are multiple actions in a queue (for example with deferred), the updated method would only get called once for the last action.
I do wonder:
def updated_search(self, search, is_last_or_only_action
.self
) which could be used, but this feel like it would expose a lot of internals that probably aren't all that useful to most people. But, theoretically I could addcomponent_request
toself
, so then component code to do something with the last action would look something like this:That seems like a lot of boilerplate code for something that should be easier for users of the framework.