feat(svm): N-05 Ambiguous Parameter Usage for fill_deadline

[md0x]

Changes proposed in this PR:

• Fixes the following issue identified by Open Zeppelin:

The deposit_v3 and deposit_v3_now functions use the same parameter name, fill_deadline, with differing semantics. In deposit_v3, it is an absolute timestamp, whereas in deposit_v3_now, it is an offset added to the current time.

The documentation lacks clarity about this distinction, increasing the likelihood of errors. Users might mistakenly pass an absolute timestamp to deposit_v3_now, leading to a computed deadline (current_time + fill_deadline_offset) that exceeds current_time + state.fill_deadline_buffer. This results in failed transactions.

Consider renaming fill_deadline in deposit_v3_now to fill_deadline_offset for clarity. Alternatively, consider improving the documentation to explicitly state the difference in semantics, including examples.

[linear]

ACX-3594 N-05 Ambiguous Parameter Usage for `fill_deadline`

[chrismaree]

you'll need to update the comment block above for fill_deadline

[md0x]

you'll need to update the comment block above for fill_deadline

Comment updated