Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svm): N-01 Incomplete or Misleading Comments #843

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Jan 7, 2025

Changes proposed in this PR:

  • Fixes the following issue identified by Open Zeppelin:

Throughout the codebase, multiple instances of incomplete or misleading comments were identified:
This comment above unsafe_deposit_v3 states that the deposit_nonce is not used to derive the deposit_id, whereas it is so used.

This comment above execute_relayer_refund_leaf states that it can only be called by the owner, whereas it can be called by anyone. For context, relay_root_bundle is the admin function where the admin provides the latest root bundles and increments the bundle ID within the program state.

This comment above execute_relayer_refund_leaf states that the structure and validation of the leaf are defined in the UMIP, but there is no link or number of the UMIP.

Fixes ACX-3577

Copy link

linear bot commented Jan 7, 2025

@md0x md0x marked this pull request as ready for review January 7, 2025 10:26
chrismaree
chrismaree previously approved these changes Jan 7, 2025
Copy link
Member

@chrismaree chrismaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great.

Reinis-FRP
Reinis-FRP previously approved these changes Jan 8, 2025
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x md0x dismissed stale reviews from Reinis-FRP and chrismaree via ea42107 January 8, 2025 15:03
@md0x md0x requested review from Reinis-FRP and chrismaree January 8, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants