Skip to content

Commit

Permalink
fix(evm): N02 - Address typographical Errors in spoke pool (#831)
Browse files Browse the repository at this point in the history
* WIP

Signed-off-by: Chris Maree <[email protected]>

* Update contracts/SpokePool.sol

---------

Signed-off-by: Chris Maree <[email protected]>
Co-authored-by: Matt Rice <[email protected]>
  • Loading branch information
chrismaree and mrice32 authored Jan 9, 2025
1 parent 3e06f77 commit 6a2f8ac
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions contracts/SpokePool.sol
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ abstract contract SpokePool is
}

/**
* @notice An overloaded version of `unsafeDepositV3` that accepts `address` types for backward compatibility. *
* @notice An overloaded version of `unsafeDepositV3` that accepts `address` types for backward compatibility.
* @dev This version mirrors the original `unsafeDepositV3` function, but uses `address` types for `depositor`, `recipient`,
* `inputToken`, `outputToken`, and `exclusiveRelayer` for compatibility with contracts using the `address` type.
*
Expand Down Expand Up @@ -1296,7 +1296,7 @@ abstract contract SpokePool is
/**
* @notice Returns the deposit ID for an unsafe deposit. This function is used to compute the deposit ID
* in unsafeDepositV3 and is provided as a convenience.
* @dev msgSenderand depositor are both used as inputs to allow passthrough depositors to create unique
* @dev msgSender and depositor are both used as inputs to allow passthrough depositors to create unique
* deposit hash spaces for unique depositors.
* @param msgSender The caller of the transaction used as input to produce the deposit ID.
* @param depositor The depositor address used as input to produce the deposit ID.
Expand Down Expand Up @@ -1501,7 +1501,7 @@ abstract contract SpokePool is
bool success = _noRevertTransfer(l2TokenAddress, refundAddresses[i], refundAmounts[i]);

// If the transfer failed then track a deferred transfer for the relayer. Given this function would
// have revered if there was insufficient balance, this will only happen if the transfer call
// have reverted if there was insufficient balance, this will only happen if the transfer call
// reverts. This will only occur if the underlying transfer method on the l2Token reverts due to
// recipient blacklisting or other related modifications to the l2Token.transfer method.
if (!success) {
Expand Down

0 comments on commit 6a2f8ac

Please sign in to comment.