Skip to content

Commit

Permalink
Unskip test_storage_capabilities.
Browse files Browse the repository at this point in the history
  • Loading branch information
aliddell committed Nov 21, 2023
1 parent dd26856 commit 79f117c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
push:
branches:
- main
pull_request_target:
pull_request: # FIXME (aliddell)
branches:
- main

Expand Down
18 changes: 13 additions & 5 deletions tests/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,10 +811,6 @@ def test_simulated_camera_capabilities(
assert camera.triggers.frame_start == (1, 0)


@pytest.mark.skip(
reason="Storage metadata is broken. See "
"https://github.com/acquire-project/acquire-video-runtime/issues/119"
)
@pytest.mark.parametrize(
("descriptor", "chunking", "sharding", "multiscale"),
[
Expand All @@ -836,6 +832,7 @@ def test_simulated_camera_capabilities(
)
def test_storage_capabilities(
runtime: Runtime,
request: pytest.FixtureRequest,
descriptor: str,
chunking: Optional[Dict[str, Any]],
sharding: Optional[Dict[str, Any]],
Expand All @@ -845,10 +842,21 @@ def test_storage_capabilities(
p = runtime.get_configuration()
p.video[0].camera.identifier = dm.select(DeviceKind.Camera, ".*empty")
p.video[0].storage.identifier = dm.select(DeviceKind.Storage, descriptor)
p.video[0].storage.settings.filename = "out"

# FIXME (aliddell): hack to get the storage capabilities to be populated
p.video[0].storage.settings.filename = f"{request.node.name}.out"

p.video[0].storage.settings.external_metadata_json = json.dumps(
{"hello": "world"}
) # for tiff-json
p.video[0].max_frame_count = 1000
runtime.set_configuration(p)

# FIXME (aliddell): hack to get the storage capabilities to be populated
runtime.start()
c = runtime.get_capabilities()
# FIXME (aliddell): hack to get the storage capabilities to be populated
runtime.abort()
storage = c.video[0].storage

assert (
Expand Down

0 comments on commit 79f117c

Please sign in to comment.