Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Display plenary talks on event page #3603

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

davidstap
Copy link
Collaborator

@davidstap davidstap commented Jun 28, 2024

Note: this is very much a work in progress!

Summary

This pull request aims to display plenary talks (e.g., these from ACL 2022) on the relevant event pages. Currently, some plenary talks are stored in data/xml but are not displayed on the website.

Display strategy

The exact method for displaying these talks is still under consideration. One option is to list the talks below the existing Website and Handbook links on the event page (see e.g., ACL 2022). Another option is to link to a dedicated page where all talks are collected.

Additionally, each talk should have a dedicated landing page, similar to how papers are presented, including the ability to cite the talk.

Rough roadmap

  • Store talks in class EventIndex when available.
  • Store talks in Hugo data folders when running bin/create_hugo_yaml.py.
  • create a Hugo layout for talks in hugo/layouts/talks.
  • Ensure talks are generated during website build (modify bin/create_hugo_pages.py)
  • Add all available talks that are stored on the server (currently only 2022.acl.xml includes talks)

@davidstap davidstap requested a review from mjpost June 28, 2024 16:51
@davidstap davidstap added this to the 2024Q2 milestone Jun 28, 2024
@davidstap davidstap self-assigned this Jun 28, 2024
@mbollmann
Copy link
Member

One thing to note is that we're in the process of changing the build scripts to use the new library in python/, so making larger changes to the stuff in bin/ now runs the risk of being deprecated very soon. Not that I want to discourage you from implementing this – we should really have this! – but to make you aware of these upcoming changes.

@davidstap
Copy link
Collaborator Author

davidstap commented Jun 29, 2024

One thing to note is that we're in the process of changing the build scripts to use the new library in python/, so making larger changes to the stuff in bin/ now runs the risk of being deprecated very soon. Not that I want to discourage you from implementing this – we should really have this! – but to make you aware of these upcoming changes.

That's good to know, thanks. In that case it makes sense to create a dummy build/data/talks/2022.acl.xml file for now instead of creating code to generate it, and then work on creating the Hugo layout for that. After the upcoming changes are implemented I can then figure out how to construct the build/data/talks/* files automatically.

@mbollmann
Copy link
Member

I'm travelling right now, but I should be able to take a closer look at your changes during the coming week and make more concrete recommendations. :)

Adding this to the Hugo templates first is a good idea in any case!

@mbollmann
Copy link
Member

Sorry that it took longer than expected to get back to this, had less time than I thought I would (... as always ...).

The new library already has functionality for accessing talks (https://acl-anthology-py.readthedocs.io/en/latest/api/event/#acl_anthology.collections.event.Talk), and I’m maybe halfway through adapting the bin/create_hugo_yaml.py and bin/create_hugo_pages.py scripts to use the new library. That said, if you feel it’s not too much work to add this to the current scripts, it should not be too much work to incorporate this into the updated scripts later. I don’t want to block you from working on this since it might take a while for the new scripts to be ready. The most substantial part should be the Hugo template anyway, which won’t be obsolete. :)

@davidstap
Copy link
Collaborator Author

Thanks for getting back to this! I’ll start by finding the unmatched plenary talks on the server and linking them to their venues in data/xml/*. This should prevent any duplicate work for both of us. Once that’s sorted, I’ll review your changes and continue working on the Hugo template :)

(Heads up, I’ll be traveling for ACL and then on holiday, so I’ll be mostly offline in August.)

@mjpost mjpost modified the milestones: 2024Q2, 2024Q4 Nov 7, 2024
@mjpost
Copy link
Member

mjpost commented Dec 16, 2024

Hi @davidstap, is this something you're still interested in? I'd love to get plenary talks posted with bibtex, as a near-term goal. For example, it would be nice to post lifetime achievement award talks.

@mjpost mjpost requested a review from mbollmann December 16, 2024 17:18
@mjpost mjpost modified the milestones: 2024Q4, 2025Q1 Dec 16, 2024
@davidstap
Copy link
Collaborator Author

Yes - I started labeling plenary talks but got sidetracked. Will complete labeling in a separate PR first, then update hugo files to handle the labeled data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants