Api shape unification #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rethink of split_path: Split is the method to create a path+name that can be found in table. So the previous logic, that treated ending / and a delimiter does not make sense. I had a feeling that it was wrong, now I know. So now: /a/b/ results in '/a/' + 'b', and / results in '' + '' which is existing root element ! This however allows acessing attrs with '/' at the end of the path - like '/value/'. Maybe this is not good. But if needed this can be guarded in `get_item` instead of `split_path`
|
... totally confused with the linter issue ... I'd propose to increase line length to 130. ? P.S. offtopic, carring to new lines the if conditions seems to me the least obvious abaplint rule. It is never intuitive how to do indentation there. I tried 0, 2, 3 chars in this case - all failed. This is abaplint topic actually, but I think something has to be done to this. Maybe change the message. Or make this rule more tolerant. |
|
So it's 4 chars after all ... ok :)))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, so
check_objectsupports unified API shape from abaplint/abaplint-sci-server#28 (abaplint/abaplint-sci-server#27 for reference)This is a dirty one. I'd like to separate API response processing to another class, but later. This approach works for now.
As a dependency improved JSON parser. Looks like it may become a separate lib :) Added
sub_sectionwhich bytes branch of json to a separate reader - useful to remove API wrapper.P.S. some comments to json code from the commits:
P.P.S would be very nice to have drilldown to issues ... :) But I have no experience with SCI internals ...