Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime to feature generation logs #525

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Dec 27, 2023

This PR adds the total runtime to the outputs logged during feature generation. This will simplify future efforts to compare runtimes and the number of initial sources per quadrant (eliminating the present need to parse slurm email subject lines for runtimes).

@bfhealy bfhealy temporarily deployed to Integrate Pull Request December 27, 2023 18:31 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request December 27, 2023 18:31 — with GitHub Actions Inactive
@mcoughlin mcoughlin self-requested a review December 27, 2023 18:52
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy merged commit c6e510f into ZwickyTransientFacility:main Dec 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants