Use JSON parser in arb_reformatter.py #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
force-pushed
the
arb-formatter-json
branch
from
dc8f314 to
f2e5450
Compare
…int warning" This reverts commit e2856ed.
emlun
force-pushed
the
arb-formatter-json
branch
from
f2e5450 to
844f2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the reformatting method to parse both dictionaries as JSON, recursively re-order the keys of the target to match that of the source, and then insert newlines where they appear in the source. Keys missing from the source are deleted from the target.