Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: enable linting against PHP 8.4 #234

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 10, 2024

Summary

This PR can be summarized in the following changelog entry:

  • Verified compatibility with PHP 8.4

Relevant technical choices:

As the PHP 8.4 build passes and the PHP 8.4 release is expected later this month, the builds are not allowed to fail.

Milestone

  • I've attached the next release's milestone to this pull request.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

As the PHP 8.4 build passes and the PHP 8.4 release is expected later this month, the builds are not _allowed to fail_.
@jrfnl jrfnl added this to the 1.19 milestone Nov 10, 2024
@jrfnl jrfnl merged commit 38b4b4c into develop Nov 10, 2024
5 checks passed
@jrfnl jrfnl deleted the JRF/ghactions-run-against-php84 branch November 10, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant