statx: commenting out unsupported struct members and define.

YoSTEALTH · Mar 6, 2024 · 22ed90b · 22ed90b
1 parent c6ff9e0
commit 22ed90b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/src/liburing/lib/statx.pxd b/src/liburing/lib/statx.pxd
@@ -35,8 +35,9 @@ cdef extern from '<linux/stat.h>' nogil:
         __u32   stx_dev_minor
         # 0x90
         __u64   stx_mnt_id
-        __u32   stx_dio_mem_align       # Memory buffer alignment for direct I/O
-        __u32   stx_dio_offset_align    # File offset alignment for direct I/O
+        # note: not supported
+        # __u32   stx_dio_mem_align       # Memory buffer alignment for direct I/O
+        # __u32   stx_dio_offset_align    # File offset alignment for direct I/O
 
     # Mask - flags to be set for `stx_mask`
     # - Query request/result mask for `statx()` and struct `statx::stx_mask`.
@@ -57,7 +58,8 @@ cdef extern from '<linux/stat.h>' nogil:
         __STATX_BASIC_STATS 'STATX_BASIC_STATS'  # [All of the above]
         __STATX_BTIME 'STATX_BTIME'              # Want|got `stx_btime`
         __STATX_MNT_ID 'STATX_MNT_ID'            # Got `stx_mnt_id`
-        __STATX_DIOALIGN 'STATX_DIOALIGN'        # Want/got direct I/O alignment info
+        # note: not supported
+        # __STATX_DIOALIGN 'STATX_DIOALIGN'        # Want/got direct I/O alignment info
 
     # Attributes to be found in `stx_attributes` and masked in `stx_attributes_mask`.
     enum:

diff --git a/src/liburing/statx.pyx b/src/liburing/statx.pyx
@@ -121,13 +121,14 @@ cdef class statx:
     def stx_mnt_id(self):
         return self.ptr.stx_mnt_id
 
-    @property
-    def stx_dio_mem_align(self):
-        return self.ptr.stx_dio_mem_align
+    # note: not supported
+    # @property
+    # def stx_dio_mem_align(self):
+    #     return self.ptr.stx_dio_mem_align
 
-    @property
-    def stx_dio_offset_align(self):
-        return self.ptr.stx_dio_offset_align
+    # @property
+    # def stx_dio_offset_align(self):
+    #     return self.ptr.stx_dio_offset_align
 
     # Inode
     # -----
@@ -222,7 +223,8 @@ cpdef inline void io_uring_prep_statx(io_uring_sqe sqe,
             STATX_BASIC_STATS   # [All of the above]
             STATX_BTIME         # Want|got `stx_btime`
             STATX_MNT_ID        # Got `stx_mnt_id`
-            STATX_DIOALIGN      # Want/got direct I/O alignment info
+            # note: not supported
+            # STATX_DIOALIGN      # Want/got direct I/O alignment info
 
         Note
             - Keep reference to `path` or else it will raise `FileNotFoundError`
@@ -249,7 +251,8 @@ STATX_BLOCKS = __STATX_BLOCKS
 STATX_BASIC_STATS = __STATX_BASIC_STATS
 STATX_BTIME = __STATX_BTIME
 STATX_MNT_ID = __STATX_MNT_ID
-STATX_DIOALIGN = __STATX_DIOALIGN
+# note: not supported
+# STATX_DIOALIGN = __STATX_DIOALIGN
 
 STATX_ATTR_COMPRESSED = __STATX_ATTR_COMPRESSED
 STATX_ATTR_IMMUTABLE = __STATX_ATTR_IMMUTABLE

diff --git a/test/statx_test.py b/test/statx_test.py
@@ -23,7 +23,8 @@ def test_statx_define():
     assert liburing.STATX_BASIC_STATS == 0x000007ff
     assert liburing.STATX_BTIME == 0x00000800
     assert liburing.STATX_MNT_ID == 0x00001000
-    assert liburing.STATX_DIOALIGN == 0x00002000
+    # note: not supported
+    # assert liburing.STATX_DIOALIGN == 0x00002000
 
     assert liburing.STATX_ATTR_COMPRESSED == 0x00000004
     assert liburing.STATX_ATTR_IMMUTABLE == 0x00000010