small improvements on docs and passing variant as argument for the fi…

…lter callback
Ympact · Nov 18, 2024 · 8541f8e · 8541f8e
1 parent 16242a8
commit 8541f8e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/src/Services/IconBuilder.php b/src/Services/IconBuilder.php
@@ -194,10 +194,10 @@ public function buildIcons()
         if ($this->variantProp($this->baseVariant, 'source.filter')) {
             $files = $files->filter(function($file) {
                 $icons = &$this->icons;
-                $res = call_user_func_array($this->variantProp($this->baseVariant, 'source.filter'),[
-                    $file,
-                    &$icons
-                ]);
+                $res = call_user_func_array(
+                    $this->variantProp($this->baseVariant, 'source.filter'),
+                    [$file, &$icons, $this->baseVariant]
+                );
                 return $res;
             });
         }
@@ -549,7 +549,7 @@ public function getVariantIconFile(string $variant, string $basename, Icon $icon
             $icons = $this->icons;
             if(!call_user_func_array(
                 $filter, 
-                [$file, &$icons]
+                [$file, &$icons, $variant]
             )){
                 $file = null;
             }

diff --git a/src/Services/Vendors/Mdi.php b/src/Services/Vendors/Mdi.php
@@ -8,12 +8,13 @@
 class Mdi
 {
     /**
-     * 
+     * Filter function to determine if the icon is an outline icon
      * @param string $file
      * @param array|null $icons
+     * @param string $variant the variant of the source icon (outline, solid, mini, micro)
      * @return boolean
      */
-    public static function outlineFilter($file, &$icons): bool
+    public static function outlineFilter($file, &$icons, $variant): bool
     {
         if($icons === null){
             $icons = [];
@@ -38,11 +39,13 @@ public static function outlineFilter($file, &$icons): bool
     }
 
     /**
-     * 
-     * @param $size size of the resource icon
+     * Filter function to determine if the icon is a solid icon
+     * @param string $file
+     * @param array|null $icons
+     * @param string $variant the variant of the source icon (outline, solid, mini, micro)
      * @return boolean
      */
-    public static function solidFilter($file, &$icons): bool
+    public static function solidFilter($file, &$icons, $variant): bool
     {
         $filename = pathinfo($file, PATHINFO_FILENAME);
         if (Str::contains($filename,'-outline')) {