Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Shouldn't be able to add a HowlFieldSchema with the same name as existing #6

Open
wants to merge 2 commits into
base: howl
Choose a base branch
from
Open

Shouldn't be able to add a HowlFieldSchema with the same name as existing #6

wants to merge 2 commits into from

Conversation

jghoman
Copy link
Contributor

@jghoman jghoman commented Feb 3, 2011

As noted in HowlSchema.java, one should not be able to append an a field schema with the same name. The code says that this requires Comparable, which is not correct, since we're not doing ordering. Technically, this requires a correct equals, but since we don't want multiple fields with the same name in a schema (particularly since we index it via the name in the accompanying map), the correct check is just based on the name. This adds the check and throws a HowlException if this occurs.

Unit test to verify is included.

Additionally, we should make it an invariant in the constructor that the list of field schemas should not include any with duplicated names. I'll do this in another issue.

@ddas
Copy link

ddas commented Feb 3, 2011

Good catch.

@jghoman
Copy link
Contributor Author

jghoman commented Feb 3, 2011

Went ahead and added check in constructor for field name uniqueness. Might as well do it now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants