-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YS-173] refact: ExperimentPost의 recruitDone
컬럼명 변경 및 공고 전체 조회 API, 지역별 공고 개수 조회 API 로직 리팩터링
#42
Changes from all commits
9d93ac5
5e7683a
68424f6
1d8ad5b
ebb8b7f
9cc158b
495b20e
fe19926
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package com.dobby.backend.infrastructure.database.entity.enums.experiment | ||
|
||
import java.security.InvalidParameterException | ||
|
||
enum class RecruitStatus { | ||
ALL, OPEN; | ||
|
||
companion object { | ||
fun fromString(value: String): RecruitStatus { | ||
return when (value) { | ||
"ALL" -> ALL | ||
"OPEN" -> OPEN | ||
else -> throw InvalidParameterException() | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 현재 enum값으로 정의한 앞서 다른 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오 그 부분은 제가 놓치고 개발했었네요. Enum으로 수정하겠습니다! 감사합니다 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존 로직에서는
모집 중인 공고 / 모집 완료인 공고
둘로 나누어 진행이 되던데 기획 상으로는모집 중인 공고 / 모든 공고
둘로 나누는 것이 맞다고 생각해 수정했습니다! 틀렸다면 알려주세요~There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CustomFilter에서는 기획 요청 상
ALL
과OPEN
으로 나누어보는 것이 맞는 것 같습니다. 👍👍