Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat#90] DTO validation 추가 #108

Merged
merged 6 commits into from
Jun 25, 2024
Merged

[feat#90] DTO validation 추가 #108

merged 6 commits into from
Jun 25, 2024

Conversation

hun-ca
Copy link
Member

@hun-ca hun-ca commented Jun 24, 2024

🎫 연관 이슈

resolved #90

💁‍♂️ PR 내용

🙏 작업

🙈 PR 참고 사항

📸 스크린샷

🤖 테스트 체크리스트

  • 체크 미완료
  • 체크 완료

@hun-ca hun-ca added the feature 새로운 기능을 만들 때 사용됩니다 label Jun 24, 2024
@hun-ca hun-ca self-assigned this Jun 24, 2024
@hun-ca hun-ca requested a review from belljun3395 as a code owner June 24, 2024 14:29
@hun-ca
Copy link
Member Author

hun-ca commented Jun 24, 2024

@belljun3395 DTO calidation 할때 에러 메시지를 String으로 직접 지정하지 않고 static file에서 참조할 수 있도록 하는 방법 아실까요?

ex. @field:Email(message = "Email should be valid") 에서 message 부분을 file에서 한번에 관리..

@belljun3395
Copy link
Collaborator

belljun3395 commented Jun 24, 2024

@belljun3395 DTO calidation 할때 에러 메시지를 String으로 직접 지정하지 않고 static file에서 참조할 수 있도록 하는 방법 아실까요?

ex. @field:Email(message = "Email should be valid") 에서 message 부분을 file에서 한번에 관리..

스크린샷 2024-06-24 오후 11 40 32 스크린샷 2024-06-24 오후 11 41 51 스크린샷 2024-06-24 오후 11 41 47

ValidationMessages.properties 만들고
안에 정의하면 됩니다~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 PR이랑은 상관없지만 Flyway파일 이름 수정헀습니다. v -> V

Comment on lines +1 to +3
email.notblank=Email must not be blank
email.invalid=Email should be valid
sub.notblank=Submitted Answer must not be blank
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런식으로 일단 추가함

Copy link
Collaborator

@belljun3395 belljun3395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~!

@belljun3395
Copy link
Collaborator

@min() 에는 메시지 안들어가나요???

@hun-ca
Copy link
Member Author

hun-ca commented Jun 25, 2024

@min() 에는 메시지 안들어가나요???

TODO

@hun-ca hun-ca requested a review from belljun3395 June 25, 2024 12:04
@belljun3395
Copy link
Collaborator

확인했슴다!

@hun-ca hun-ca merged commit 6633100 into main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능을 만들 때 사용됩니다
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request dto validator 추가
2 participants