Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) { | ||
|
|
||
| public static ArchiveUnitResult of(Archive archive) { | ||
| if (archive.getTemplate() == null) { |
There was a problem hiding this comment.
archive에 메서드로 표현해도 좋아보여요
Suggested change
| if (archive.getTemplate() == null) { | |
| if (archive.isMemo()) { |
There was a problem hiding this comment.
오! 감사합니다 적용해놓을게요
| this.content = content; | ||
| this.template = template; | ||
| public Archive(Member member, MemoFolder memoFolder, MemoContent content, Template template) { | ||
| this(null, member, memoFolder, content, template); |
Comment on lines
30
to
37
| return switch (query.tab()) { | ||
| case ALL -> archiveRepository.findAllArchives(query.memberId(), query.folderId()) | ||
| .stream().map(ArchiveUnitResult::of).collect(Collectors.toList()); | ||
| case MEMO -> archiveRepository.findAllArchivedMemos(query.memberId(), query.folderId()) | ||
| .stream().map(ArchiveUnitResult::of).collect(Collectors.toList()); | ||
| case TEMPLATE -> archiveRepository.findAllArchivedTemplates(query.memberId(), query.folderId()) | ||
| .stream().map(ArchiveUnitResult::of).collect(Collectors.toList()); | ||
| }; |
|
|
||
| @GetMapping | ||
| public ResponseEntity<List<ArchiveUnitResult>> getArchive(AuthMember member, | ||
| @RequestBody GetArchiveRequest request) { |
There was a problem hiding this comment.
GET 요청에는 queryParam으로 담는게 나을 것 같아요
@ModelAttribute로 선언해도 괜찮겠네요
There was a problem hiding this comment.
tabName(전체, 끄적이는, 참고하는) 말씀하신게 맞을까요?? 그렇다면 pathvariable은 어떨까요?
There was a problem hiding this comment.
네네 GetArchiveRequest에 folderId랑 tabName 이 있는데 body말고 다른 걸로 표현되면 됩니다!
/archives/folder/{folderId}?tabName={}
이런식은 어떤가요?
There was a problem hiding this comment.
좋네욥 👍🏼👍🏼 말씀해주신대로 반영해보았는데, 확인 부탁드립니다~!
TaeyeonRoyce
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련된 이슈
BAR-113
작업 사항