Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array changes for half #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Array changes for half #308

wants to merge 2 commits into from

Conversation

PhilipDeegan
Copy link
Member

@andro2157 kudos to

@PhilipDeegan PhilipDeegan self-assigned this Oct 16, 2018
@PhilipDeegan PhilipDeegan requested a review from Mbompr October 16, 2018 15:16
@PhilipDeegan PhilipDeegan removed the wip label Oct 16, 2018
Mbompr
Mbompr reviewed Oct 16, 2018
View reviewed changes
lib/cpp-test/array/array_gtest.cpp Outdated Show resolved Hide resolved
lib/cpp-test/array/array_gtest.cpp Outdated Show resolved Hide resolved
lib/cpp-test/array/array_gtest.cpp Outdated Show resolved Hide resolved
lib/cpp-test/array/array_gtest.cpp Outdated Show resolved Hide resolved
lib/cpp-test/array/array_gtest.cpp Outdated Show resolved Hide resolved
lib/cpp-test/array/array_gtest.cpp Outdated Show resolved Hide resolved
lib/include/tick/array/abstractarray1d2d.h Outdated Show resolved Hide resolved
lib/include/tick/array/promote.h Outdated Show resolved Hide resolved
@PhilipDeegan PhilipDeegan mentioned this pull request Dec 14, 2018
Open
@stephanegaiffas
Copy link
Collaborator

Where were we with this one ? It's a pretty cool feature !

@PhilipDeegan
Copy link
Member Author

There's apparently some built in half_float in clang, and maybe else where, so I'm going to check that out

@PhilipDeegan
Copy link
Member Author

Otherwise it works, we might want to look at some form of bounds checking as things get a little strange after 3/4 decimal places

@PhilipDeegan
Copy link
Member Author

clang seems to have support for float16 - perhaps we could right some tests based on that and make the other lib adhere?

@PhilipDeegan
Copy link
Member Author

seems that clang fl16 only works on ARM :|

@PhilipDeegan
Copy link
Member Author

ROCm/hcc#1128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mbompr Mbompr Mbompr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@PhilipDeegan PhilipDeegan

Labels
enhancement help wanted new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilipDeegan @stephanegaiffas @Mbompr