Update ToC styles for Developer redesign #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
changed the title
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #491
Updates styles to match the Developer article designs.
Largely follows the styles added to the Developer Chapter List block in WordPress/wporg-developer#353
The ToC should be collapsed by default on mobile and tablet (screens < 1200px wide), and expanded on larger screens where it can sit alongside the content. No change to fixed/scrolling sidebar behaviour.
NOTE: Does not make changes to scrolling behaviour, including visibility of 'Back to top' at top of page, and styling of the active/closest ToC title.
Screenshots
Desktop
Tablet
Mobile
Testing
This should be tested with both Developer and Documentation sites.
Ensure your mu-plugins is on this branch and styles are built.
Check at different screen sizes; behaviour is different at < 768px, between 768px and 1199px, and >= 1200px.
Check both state on page load, and on screen orientation change.