Fix rendering callout blocks as notice blocks (#662)

* Revert "Revert "Render Callout blocks as Notice blocks (#658)" (#659)"

This reverts commit 80dfeb4.

* Only disable o2 filters if the class exists

* Stop running filters on callout content

* Switch to using CSS to avoid o2 script tags from affecting layout

Hide empty p tags and remove margin from second to last element if there is an o2-data script tag.

* Allow for first or last elements being empty

Adjust margins on second and second to last elements accordingly

* 💄 Move comment

* Fix scope for content layout adjustments

* Fix br selectors

mu-plugins/blocks/notice/index.php

@@ -9,6 +9,8 @@
 // Run after `WPorg_Handbook_Callout_Boxes` registers the shortcodes.
 add_action( 'init', __NAMESPACE__ . '\init', 11 );
 
+add_filter( 'pre_render_block', __NAMESPACE__ . '\render_callout_block_as_notice', 11, 2 );
+
 /**
  * Registers the block using the metadata loaded from the `block.json` file.
  * Behind the scenes, it registers also all assets so they can be enqueued
@@ -21,20 +23,20 @@ function init() {
 
 	foreach ( [ 'info', 'tip', 'alert', 'tutorial', 'warning' ] as $shortcode ) {
 		remove_shortcode( $shortcode );
-		add_shortcode( $shortcode, __NAMESPACE__ . '\render_shortcode' );
+		add_shortcode( $shortcode, __NAMESPACE__ . '\render_callout_as_notice' );
 	}
 }
 
 /**
- * Display the callout shortcodes using the notice block.
+ * Display a callout using the notice block.
  *
- * @param array|string $attr    Shortcode attributes array or empty string.
- * @param string       $content Shortcode content.
- * @param string       $tag     Shortcode name.
+ * @param array|string $attr    Callout shortcode attributes array or empty string.
+ * @param string       $content Callout content.
+ * @param string       $tag     Callout type.
  *
- * @return string Shortcode output as HTML markup.
+ * @return string Callout output as HTML markup.
  */
-function render_shortcode( $attr, $content, $tag ) {
+function render_callout_as_notice( $attr, $content, $tag ) {
 	$shortcode_mapping = array(
 		'info'     => 'info',
 		'tip'      => 'tip',
@@ -70,3 +72,28 @@ function render_shortcode( $attr, $content, $tag ) {
 
 	return $final_markup;
 }
+
+/**
+ * Renders a callout block as a notice.
+ *
+ * @param string|null $pre_render The pre-rendered content or null.
+ * @param array       $parsed_block The parsed block array.
+ * @return string|null The rendered notice or the original pre-render value.
+ */
+function render_callout_block_as_notice( $pre_render, $parsed_block ) {
+	if ( is_admin() || 'wporg/callout' !== $parsed_block['blockName'] ) {
+		return $pre_render;
+	}
+
+	$callout_wrapper = $parsed_block['innerHTML'];
+	// Extract the specific "callout-*" class and remove the "callout-" prefix
+	preg_match( '/\bcallout-([\w-]+)\b/', $callout_wrapper, $matches );
+	$tag = $matches[1] ?? 'tip';
+
+	$content = '';
+	foreach ( $parsed_block['innerBlocks'] as $inner_block ) {
+		$content .= render_block( $inner_block );
+	}
+
+	return render_callout_as_notice( '', $content, $tag );
+}

mu-plugins/blocks/notice/postcss/style.pcss

@@ -27,18 +27,6 @@
 		align-self: start;
 	}
 
-	& p:first-child {
-		margin-block-start: 0;
-	}
-
-	& p:last-child {
-		margin-block-end: 0;
-	}
-
-	& br:first-child {
-		display: none;
-	}
-
 	&.alignleft,
 	&.alignright {
 		max-width: calc(var(--wp--style--global--content-size, 680px) * 0.66);
@@ -78,4 +66,23 @@
 
 .wp-block-wporg-notice__content {
 	align-self: center;
+
+	& :empty:not(br),
+	& br:first-child {
+		display: none;
+	}
+
+	& :first-child,
+	&:has(:first-child:empty) :nth-child(2) {
+		margin-block-start: 0;
+	}
+
+	& :last-child,
+	&:has(:last-child:empty) :nth-last-child(2),
+	/* o2 adds a data script tag to the notice content on some Make blogs.
+	 * In this case we need to remove bottom margin from the second to last element instead.
+	 */
+	&:has(.o2-data) :nth-last-child(2) {
+		margin-block-end: 0;
+	}
 }