Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline code padding and use border-radius variable #447

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Update inline code padding and use border-radius variable #447

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16766c3
Update code padding and use border-radius var.
ndiego Dec 16, 2023
d04799c
Remove redundant styles.
renintw Jan 22, 2024
39fb3f1
Replace button with code for a better semantics.
renintw Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions source/wp-content/themes/wporg-developer-2023/src/style/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,17 @@ pre {
padding: 20px;
background-color: #f7f7f7;
border: 1px solid var(--wp--preset--color--light-grey-1);
border-radius: 2px;
border-radius: var(--wp--custom--button--border--radius);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is the same value, semantically it's a different use, and I think we should add a new custom var

Suggested change
border-radius: var(--wp--custom--button--border--radius);
border-radius: var(--wp--custom--code--border--radius);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting adding style in the parent theme here? If so, do you think we should also include the complete styling for the code here, like the color of the code, padding, etc.? Perhaps we can ask the design team to provide a standard design for the code.

And what do you think we should call this? I reckon a callout is not a typical button or code?

"code": {
	"border": {
		"color": "var(--wp--preset--color--light-grey-1)",
		"radius": "2px",
		"style": "solid",
		"width": "1px"
	}
},

Or you're just referring to adding something like these two.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

"code": {
	"border": {
		"radius": "2px",
	}
},

Yep exactly that. I guess it makes sense to add it to parent, even if most child themes might not use it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what do you think we should call this? I reckon a callout is not a typical button or code?

Callouts are definitely different, not sure what you're asking here sorry... can you expand on it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. I'm referring to the button in the --wp--custom--button--border--radius.
Since this border radius belongs to a callout, I assume we also want it to be something like --wp--custom--callout--border--radius.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom code block style has been added to parent. And the button has also been replaced with code here through 39fb3f1.

Results

image
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. I'm referring to the button in the --wp--custom--button--border--radius. Since this border radius belongs to a callout, I assume we also want it to be something like --wp--custom--callout--border--radius.

Sorry I get it now. Yeah I don't think this change should be included, unless we're going to update the mu-plugins callout styles to also use a var.

overflow: scroll;
}

code {
display: inline-block;
line-height: var(--wp--custom--body--extra-small--typography--line-height);
background: var(--wp--preset--color--light-grey-2);
border-radius: 2px;
padding-inline-start: 3px;
padding-inline-end: 3px;
border-radius: var(--wp--custom--button--border--radius);
padding-inline-start: 0.25em;
padding-inline-end: 0.25em;
renintw marked this conversation as resolved.
Show resolved Hide resolved
max-width: 100%;
}

Expand Down Expand Up @@ -185,7 +185,7 @@ pre {
padding: 4px 6px;
background-color: var(--wp--preset--color--light-grey-2);
font-size: var(--wp--preset--font-size--small);
border-radius: 2px;
border-radius: var(--wp--custom--button--border--radius);
}

.wporg-dot-link-list {
Expand Down Expand Up @@ -435,7 +435,7 @@ pre {

.wporg-developer-code-block {
$half_padding: calc(var(--wp--preset--spacing--10) / 2);
$border_radius: 2px;
$border_radius: var(--wp--custom--button--border--radius);

.wp-code-block-button-container {
background-color: var(--wp--preset--color--light-grey-2);
Expand Down Expand Up @@ -633,7 +633,7 @@ pre {
color: var(--wp--custom--wporg-callout--color--text);
background-color: var(--wp--custom--wporg-callout--color--background);
border-width: 0;
border-radius: 2px;
border-radius: var(--wp--custom--button--border--radius);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should revert this, as it's a value copied from mu-plugins, see comment.

font-size: var(--wp--preset--font-size--small);

&::before {
Expand Down
Loading