Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/selenium #461

Merged
merged 18 commits into from
Dec 9, 2024
Merged

Fix/selenium #461

merged 18 commits into from
Dec 9, 2024

Conversation

flashdesignory
Copy link
Contributor

@flashdesignory flashdesignory commented Dec 2, 2024

Testing a potential fix for #460

@flashdesignory flashdesignory marked this pull request as ready for review December 2, 2024 18:07
@camillobruni
Copy link
Contributor

I'll have a look tomorrow.
I did something similar with JetStream, there is sometimes a race-condition when the selenium code is execute vs the ready-events were sent.

See WebKit/JetStream#11

@flashdesignory
Copy link
Contributor Author

I'll have a look tomorrow. I did something similar with JetStream, there is sometimes a race-condition when the selenium code is execute vs the ready-events were sent.

See WebKit/JetStream#11

Yeah I noticed the race condition happening, intermittently.
Increasing any timeouts didn't work for me consistently, but using the global flags with a check-in function seems to work locally and in CI consistently now 🤞

tests/index.html Outdated Show resolved Hide resolved
tests/run.mjs Outdated Show resolved Hide resolved
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like this version much more than the previous one :-)

I just left 2 optional comments for correctness, but otherwise this looks good to me

tests/run.mjs Outdated Show resolved Hide resolved
tests/index.html Outdated Show resolved Hide resolved
flashdesignory and others added 2 commits December 9, 2024 07:56
@flashdesignory flashdesignory merged commit e2e3c49 into WebKit:main Dec 9, 2024
4 checks passed
@flashdesignory flashdesignory deleted the fix/selenium branch December 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants