-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/selenium #461
Fix/selenium #461
Conversation
I'll have a look tomorrow. |
Yeah I noticed the race condition happening, intermittently. |
93c5a44
to
c3980dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like this version much more than the previous one :-)
I just left 2 optional comments for correctness, but otherwise this looks good to me
Co-authored-by: Julien Wajsberg <[email protected]>
Testing a potential fix for #460