-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Runner with Message Channel #458
Open
flashdesignory
wants to merge
30
commits into
WebKit:main
Choose a base branch
from
flashdesignory:feature/async-runner-message-channel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b594115
git branch
flashdesignory f154a4c
initial change
flashdesignory 9459c00
add event
flashdesignory d462764
add comment
flashdesignory d037f89
rollback requestIdleCallback
flashdesignory 79f8450
run format
flashdesignory 14f1f6d
undo newssite changes
flashdesignory d08606d
remove test test
flashdesignory 4540937
Merge branch 'main' into feature/async-runner
flashdesignory a02d7cc
merge main
flashdesignory 5281af4
Merge branch 'main' into feature/async-runner
flashdesignory d4fa570
Merge branch 'main' into feature/async-runner
flashdesignory 764b61b
cleanup
flashdesignory ace8c3b
reset news site build files
flashdesignory 147c38f
initial refactor
flashdesignory 92f9024
Merge branch 'main' into feature/async-runner-message-channel
flashdesignory 7cca4e0
pr feedback
flashdesignory 2b92c1f
remove async from next.js steps
flashdesignory acc7522
use static Message Channel
flashdesignory c778807
Merge branch 'main' into feature/async-runner-message-channel
flashdesignory 211ba6a
cleanup
flashdesignory 81b815e
cleanup test-runner
flashdesignory 37ffb46
fix tests
flashdesignory 63910a3
only opt in react based workloads
flashdesignory 6b6f8d4
remove label getters
flashdesignory 110c94a
Merge branch 'main' into feature/async-runner-message-channel
flashdesignory a8a4059
Merge branch 'main' into feature/async-runner-message-channel
flashdesignory 05ce8bf
fix bad merge
flashdesignory 930472c
add developer menu option for async type
flashdesignory 4b69e1d
run format
flashdesignory File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of changing the test runner based on the suite type for some suites, can we initially add a toggle to developer menu so that we can try out async runner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding the agreement in the meeting was to unconditionally enable the new runner for the preact workloads and add the global developer-mode menu in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct - below is the list on enabled suites (for now):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're doing that, we need before/after numbers across browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll run crossbench for the ones on the list and post results here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are metrics for the next.js workload:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So Safari's total time goes up while the total time for Chrome & Firefox both go down? With that kind of magnitude of a difference, we need a much more thorough investigation before we can approve of the change. I suggest we land this method initially as an optional developer-menu only feature instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add an option for the developer menu 👍