-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Workload: Responsive Design #453
base: main
Are you sure you want to change the base?
Conversation
1da5897
to
34a545e
Compare
Adding reviewers for visibility, feel free to take a look :) |
It seems to me that the test doesn't really take the advantage of responsive design since iframe's size is always same. Maybe we should add steps to resize iframe so that responsive design comes into play? |
Currently, we are resizing the the iframe with id |
Oh, I see. We're resizing the inner iframe. I guess that works. |
Gentle ping 😄 |
I still see rather short run times for individual steps (close to 1.6ms in chrome canary) which might introduce a bit too much noise in the long run.
ScrollToChatAndSendMessage and (and especially it's sub-items) will show some aliasing from timer resolution which is ~ 0.1ms on chrome. |
<title>Cooking with Lit and Tailwind</title> | ||
</head> | ||
<body style="overflow: hidden; margin: 0"> | ||
<iframe title="Cooking Website with Recipes" id="content-iframe" src="iframe.html" width="800px" height="600px" style="border: none"></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we start off with 100% width/height as the maximum size (the step-resize sounds ok to be done with explicit sizes again)?
Albeit not fully exposed, we can set a custom viewport size in the params.mjs and it's used in the runner.
This workload would currently not support this directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
To bump up the step durations, I am thinking of
currently no proposed changes for |
I'll add a fix for that. The webpage was designed to be viewed in 800x600, as that's how it will appear within the benchmark.
Yes, that is expected. Do we prefer a different behavior?
Yes, they are just placeholders. We intended the video elements to be there but did not plan for them to play any actual videos. |
I guess it makes sense for the tests, since it shifts elements on the page. That said, it's not something you'd see on the web (hopefully). I'd expected a modal or something like that instead.
Thanks for clarifying. |
@issackjohn - maybe rebase / merge main, to get the updated test runner in there. That should ensure the checks don't fail. |
Let's aim for > 5ms for each measured subtest (I'd still aim for roughly 10ms if possible). Does this sound reasonable? |
Sounds good. |
Sounds reasonable to me, I'll add some more actions. |
* height and width 100% * feat: add querySelectorAllInShadowRoot method for shadow DOM element selection * feat: add functionality to click all "show more" buttons in shadow DOM during tests
cd96d0b
to
3413c3d
Compare
Just double checked on Chrome, Firefox, Safari and the noise levels are in-sync with the rest of the workloads. |
This pull request introduces a new experimental responsive design workload, featuring a single-page cooking website built with Lit and Tailwind CSS.
The hosted version can be found here.
Quick link to dev mode with workload selected.
Please look at the README in
experimental/responsive-design
for more information about the code and how it is organized.Not included in this PR: