TodoMVC web component: change css rule, run build on complex #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for rebuilding the complex version, looks like it wasn't updated in #314. |
|
Do we have before/after numbers? |
|
chrome before: chrome after: firefox before: firefox after: safari before: safari after: edge before: edge after: |
|
Thanks |
rniwa
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
word-wrap: break-wordfor consistency. The web component version actually also uses truncation, so it doesn't have any visual effect. Reason why I think it's still relevant is that we have an open issue in the official css package as well: tastejs/todomvc-app-css#40additionally, I don't know why the complex version has more changes after running the build script.
Maybe another pr merged an older version "over" my previous changes? 🤷 .
@kara