Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes <!--- #1 nasa#7948 ---!>
Describe your changes:
This PR introduces a significant architectural improvement to OpenMCT's notification system by introducing a dedicated NotificationManager class and enhancing the NotificationAPI. The changes provide a more robust and flexible notification system while maintaining backward compatibility.
Key Changes
Introduces a new NotificationManager class to handle core notification logic
Adds support for notification grouping to manage related notifications
Implements a comprehensive priority system considering multiple factors
Adds support for custom notification categories
Introduces persistent notifications that resist auto-dismissal
Improves notification lifecycle management
Benefits
Better separation of concerns between API interface and notification management
Enhanced developer experience with more powerful notification APIs
Improved organization of notifications through grouping capability
More flexible notification categorization and prioritization
Better management of system-critical notifications through persistence
Implementation Details
The implementation splits the existing notification logic into two main components:
NotificationManager: Handles core notification management, grouping, and prioritization
Enhanced NotificationAPI: Provides an improved interface while maintaining backward compatibility
Testing
Added comprehensive test coverage for new functionality including:
NotificationManager unit tests
Enhanced NotificationAPI tests
Group management tests
Category and priority system tests
The changes are fully backward compatible and require no changes to existing notification usage.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist