Skip to content

Commit

Permalink
Minor Popup Adjustments
Browse files Browse the repository at this point in the history
- Users were complaining that despawn timers felt less visible since they're on the left when all of the other "important" info is on the right, so this swaps the despawn timer with the first/last seen timers.

- Fix IVs from incorrectly calculating/displaying null values for users without IV perms
  • Loading branch information
TurtIeSocks committed Apr 12, 2021
1 parent f57e26a commit 3c098f4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions static/css/popups.css
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
}

.pokemon-despawn-timers {
grid-column: 1;
grid-column: 2;
grid-row: 5;
margin: auto;
padding: 5px;
Expand All @@ -89,7 +89,7 @@
}

.pokemon-other-timers {
grid-column: 2;
grid-column: 1;
grid-row: 5;
margin: auto;
padding: 5px;
Expand Down
2 changes: 1 addition & 1 deletion static/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3077,7 +3077,7 @@ const getPokemonPopupContent = (pokemon) => {
}

const getIV = (pokemon) => {
if (pokemon.atk_iv !== null && popupDetails.pokemon.iv) {
if (pokemon.atk_iv !== null && pokemon.atk_iv !== undefined && popupDetails.pokemon.iv) {
const ivColors = { 0: 'red', 66: 'orange', 82: 'yellow', 100: 'green' }
const ivPercent = ((pokemon.atk_iv + pokemon.def_iv + pokemon.sta_iv) / .45).toFixed(2);
let selectedColor
Expand Down

0 comments on commit 3c098f4

Please sign in to comment.