Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Verify2 SMS from field #501

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat: Add Verify2 SMS from field #501

merged 1 commit into from
Dec 18, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Dec 13, 2023

Adds the from field to com.vonage.client.verify2.SmsWorkflow.

@SMadani SMadani requested a review from SecondeJK December 13, 2023 18:07
SecondeJK
SecondeJK requested changes Dec 13, 2023
View reviewed changes
Copy link

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should have added in the requirements that from is optional - and I can't -see- any optional modifiers here

@SMadani
Copy link
Contributor Author

SMadani commented Dec 14, 2023

Sorry I should have added in the requirements that from is optional - and I can't -see- any optional modifiers here

It is optional - there are two other constructors that don't use from and it can be null too.

@SMadani SMadani requested a review from SecondeJK December 14, 2023 16:55
@SMadani SMadani merged commit 1d3f62c into main Dec 18, 2023
12 checks passed
@SMadani SMadani deleted the verify2-sms branch December 18, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SecondeJK SecondeJK SecondeJK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SMadani @SecondeJK