Add Date picker #237
Open
Add Date picker #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 98.83% 98.85% +0.02%
==========================================
Files 71 74 +3
Lines 1625 1658 +33
Branches 484 489 +5
==========================================
+ Hits 1606 1639 +33
- Misses 18 19 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
asimonok
requested changes
Jan 9, 2025
| @@ -15,6 +15,7 @@ export enum DisplayMode { | |||
| */ | |||
| export enum MinimizeOutputFormat { | |||
| TEXT = 'text', | |||
| DATE_TIME = 'dateTime', | |||
There was a problem hiding this comment.
please rename to DATETIME to be consistent over plugins
| describe('getDateInLocalTimeFormat', () => { | ||
| it('formats date correctly for standard date', () => { | ||
| const date = new Date('2025-01-09T00:00:00'); | ||
| expect(getDateInLocalTimeFormat(date)).toBe('2025-01-09'); |
There was a problem hiding this comment.
please use toEqual also for consistency
| if (typeof date === 'string') { | ||
| currentValue = date.split('T')[0]; | ||
| } else { | ||
| currentValue = isUseLocalTime ? getDateInLocalTimeFormat(date) : date.toISOString().split('T')[0]; |
There was a problem hiding this comment.
can we use dateTimeFormat to format date string?
https://github.com/grafana/grafana/blob/9e8c1acd005b8ad0a8cc025cd633ef697047e1dd/packages/grafana-ui/src/components/DateTimePickers/DateTimePicker/DateTimePicker.tsx#L221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #236