fixed travis warnigns for type comparison

VisualDataWeb · Jul 3, 2017 · b74d5eb · b74d5eb
1 parent 3bc1941
commit b74d5eb
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/src/app/js/app.js b/src/app/js/app.js
@@ -70,7 +70,7 @@ module.exports = function () {
 			d3.select("#logo").classed("hidden", true);
         } else {
 			d3.select("#logo").classed("hidden", false);
-			if (agentVersion==12) {
+			if (agentVersion===12) {
                 d3.select("#browserCheck").classed("hidden", false);
                 d3.select("#killWarning").classed("hidden", false);
             } else {
@@ -184,7 +184,7 @@ module.exports = function () {
 		navigationMenu.updateVisibilityStatus();
 		// update also the padding options of loading and the logo positions;
 		var warningDiv=d3.select("#browserCheck");
-		if (warningDiv.classed("hidden")==false ) {
+		if (warningDiv.classed("hidden")===false ) {
             var offset=10+warningDiv.node().getBoundingClientRect().height;
             d3.select("#logo").style("padding", offset+"px 10px");
         }else {

diff --git a/src/app/js/menu/searchMenu.js b/src/app/js/menu/searchMenu.js
@@ -106,7 +106,7 @@ module.exports = function (graph) {
 				var allSame=true;
 				// using simple for-loop since id list should be small
 				for (var x=0;x<correspondingIdList.length;x++){
-					if (correspondingIdList[x]!=firstVal){
+					if (correspondingIdList[x]!==firstVal){
 						allSame=false;
 					}
 				}

diff --git a/src/webvowl/js/elements/drawTools.js b/src/webvowl/js/elements/drawTools.js
@@ -157,9 +157,6 @@ module.exports = (function () {
 			.attr("r", radius + 15);
         haloGroupElement.attr("animationRunning",true);
 
-		console.log("added halo element with animation" +haloGroupElement.attr("animationRunning"));
-
-
 
         haloGroupElement.node().addEventListener("webkitAnimationEnd", function(){
             var test=haloGroupElement.selectAll(".searchResultA");

diff --git a/src/webvowl/js/elements/properties/BaseProperty.js b/src/webvowl/js/elements/properties/BaseProperty.js
@@ -432,8 +432,11 @@ module.exports = (function () {
             	var haloGr=that.getHalos();
                 var haloEls= haloGr.selectAll(".searchResultA");
                 animRuns=haloGr.attr("animationRunning");
-                // parse this to a boolean value
-                animRuns= (animRuns  == 'true');
+
+				if (typeof animRuns !== "boolean") {
+                    // parse this to a boolean value
+                    animRuns = (animRuns === 'true');
+                }
                 if (animRuns===false) {
                     haloEls.classed("searchResultA", false);
                     haloEls.classed("searchResultB", true);

diff --git a/src/webvowl/js/graph.js b/src/webvowl/js/graph.js
@@ -676,7 +676,6 @@ module.exports = function (graphContainerSelector) {
         var cp=getWorldPosFromScreen(cx,cy,graphTranslation,zoomFactor);
         var sP=[cp.x,cp.y,graph.options().height()/zoomFactor];
 
-        var zoomLevel=Math.max(defaultZoom+0.5*defaultZoom,defaultTargetZoom);
         var zoomLevel=Math.max(defaultZoom+0.5*defaultZoom,defaultTargetZoom);
         var eP=[target.x,target.y,graph.options().height()/zoomLevel];
 		var pos_intp=d3.interpolateZoom(sP,eP);