Fix a regression and refactor some functions to a better location #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hoffman
commented
Dec 8, 2023
•
tim-hoffman
commented
- Fix regression introduced when converting panics to meaningful error messages. There was one location where the panic was caught and ignored so a Result::Err should have also been ignored in that location but was not.
- Move helper functions for creating error messages into the error.rs file instead of the module file for the interpreter.
The error result in this case should not have been propagated up the call stack, just as the old implementation caught the panic instead of letting it crash the program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.