Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAN-723] Track array load/store info to only generate used functions #63

Merged
merged 6 commits into from
Oct 24, 2023
Merged

[VAN-723] Track array load/store info to only generate used functions #63

merged 6 commits into from
Oct 24, 2023

Conversation

iangneal
Copy link

  • Record load/store info from the UnknownIndexSanitizationPass in LLVMCircuitData so that only the required load
  • Removes about 3MB of LLVM IR from BrokenSemaphore mains
  • Compiler runtime seems pretty similar (just a couple of seconds per main still)
  • Vanguard runtime seems pretty similar if not a bit faster (10-30 seconds from some ad-hoc testing)

tim-hoffman
tim-hoffman reviewed Oct 24, 2023
View reviewed changes
Copy link

@tim-hoffman tim-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if more explanation is needed on any of the comments.

circuit_passes/src/passes/mod.rs Show resolved Hide resolved
compiler/src/circuit_design/circuit.rs Outdated Show resolved Hide resolved
code_producers/src/llvm_elements/array_switch.rs Outdated Show resolved Hide resolved
code_producers/src/llvm_elements/array_switch.rs Outdated Show resolved Hide resolved
@iangneal iangneal requested a review from tim-hoffman October 24, 2023 16:47
@iangneal iangneal changed the base branch from llvm to llvm-v2 October 24, 2023 18:19
@iangneal
Copy link
Author

I changed the base to llvm-v2

tim-hoffman
tim-hoffman approved these changes Oct 24, 2023
View reviewed changes
Copy link

@tim-hoffman tim-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to squash and merge into llvm-v2
Thanks!

@iangneal iangneal merged commit d4130d6 into llvm-v2 Oct 24, 2023
2 checks passed
@tim-hoffman tim-hoffman deleted the iangneal/VAN-723 branch October 24, 2023 18:28
tim-hoffman pushed a commit that referenced this pull request Oct 31, 2023
@iangneal @tim-hoffman
[VAN-723] Track array load/store info to only generate used functions (…
b5f98f6 
…#63)

* Update array function tracking
* Update test
* Clean up compiler output
tim-hoffman pushed a commit that referenced this pull request Nov 8, 2023
@iangneal @tim-hoffman
[VAN-723] Track array load/store info to only generate used functions (…
c86e965 
…#63)

* Update array function tracking
* Update test
* Clean up compiler output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-hoffman tim-hoffman tim-hoffman approved these changes

@0xddom 0xddom Awaiting requested review from 0xddom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iangneal @tim-hoffman