[VAN-718] extract large array param init to new function #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xddom
requested changes
Oct 16, 2023
|
The algorithmic part LGTM. I just have comments on the module organization |
Also temporarily XFAIL tests that are affected by this. This entire commit should be reverted before merging the PR.
tim-hoffman
force-pushed
the
th/van-718
branch
from
221dac2 to
5d19490
Compare
0xddom
approved these changes
Oct 18, 2023
tim-hoffman
force-pushed
the
th/van-718
branch
from
dbfc8a6 to
d61d603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.